jpawlowski/hass.tibber_prices
1
0
Fork 0
mirror of https://github.com/jpawlowski/hass.tibber_prices.git synced 2026-05-28 18:43:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(repairs): respect dismissal of statistics-review repair issue

Browse source 
The previous implementation used delete + create on every async_setup_entry,
which reset dismissed_version and forced the issue to reappear after every
HA restart regardless of whether the user had dismissed it.

Fix: use async_create_issue (internally get-or-create, preserves
dismissed_version when params are unchanged) instead of delete + create.
The options flow still uses delete + create when the mode changes again,
ensuring the issue is forced into view for any new change.

Also auto-clear the DATA_STATISTICS_REVIEW_REQUIRED flag from
config_entry.data when the issue is detected as dismissed on setup,
so the flag does not linger indefinitely after the user has acknowledged
the issue.

Released-Bug: no
This commit is contained in:
Julian Pawlowski 2026-04-15 09:37:54 +00:00
parent e5474d50ec
commit 5b5d5e73b0
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
custom_components/tibber_prices/__init__.py
View file

@ -215,17 +215,26 @@ def _get_access_token(hass: HomeAssistant, entry: ConfigEntry) -> str:
def _check_statistics_review_repair(hass: HomeAssistant, entry: TibberPricesConfigEntry) -> None: def _check_statistics_review_repair(hass: HomeAssistant, entry: TibberPricesConfigEntry) -> None:
"""Re-create the statistics-review repair issue fresh on every setup when the flag is set. """Ensure the statistics-review repair issue is visible when the flag is set.
Using delete + create (instead of get_or_create) resets dismissed_version, so the issue Uses async_get_or_create so that a user-dismissed issue stays dismissed across restarts.
reappears in the Repairs panel even if the user had dismissed it before a restart. The flag is cleared automatically when the issue has been dismissed (detected on next setup),
The flag is cleared from config_entry.data only when the user acknowledges the change or when the user re-saves the currency display settings in the options flow.
by re-saving the currency display settings in the options flow. The options flow uses delete + create whenever the mode changes again, which forces the
issue back into view for the new change regardless of prior dismissal.
""" """
if not entry.data.get(DATA_STATISTICS_REVIEW_REQUIRED): if not entry.data.get(DATA_STATISTICS_REVIEW_REQUIRED):
return return
issue_id = f"currency_display_mode_changed_{entry.entry_id}" issue_id = f"currency_display_mode_changed_{entry.entry_id}"
ir.async_delete_issue(hass, DOMAIN, issue_id)
# If the issue was dismissed by the user, clear the flag and don't recreate it.
issue_registry = ir.async_get(hass)
existing = issue_registry.async_get_issue(DOMAIN, issue_id)
if existing is not None and existing.dismissed_version is not None:
new_data = {k: v for k, v in entry.data.items() if k != DATA_STATISTICS_REVIEW_REQUIRED}
hass.config_entries.async_update_entry(entry, data=new_data)
return
ir.async_create_issue( ir.async_create_issue(
hass, hass,
DOMAIN, DOMAIN,